0xMiden / 0xMiden/protocol

Rename `seed` to `id_salt` to avoid confusion with wallet **seed** phrases

Open
#1,992 5 comments 2 reactions 1 assignee Claimed by @Peponks9 View on GitHub
Dominant language
Rust
Stars
132
Forks
167
Avg merge
1d 23h
Merged PRs (30d)
110

Description

The term `seed` in Miden refers to a value used during account ID generation. This is fundamentally different from how "seed" is used in Ethereum/Bitcoin, where it refers to BIP39 mnemonic phrases for hierarchical key derivation and wallet recovery.

This terminology overlap is confusing for developers coming from the Ethereum ecosystem.

I (re-)realized this when reviewing https://github.com/0xMiden/miden-base/pull/1805/, and there the `AccountDataExport` actually includes "seed", which is counterintuitive.

### Proposal

Rename `seed` -> `account_salt`

Alternatives:
- `id_salt` - shorter but less explicit, might also be confusing
- `account_id_salt` (my second favorite)
- `account_genesis_salt` - emphasizes one-time use, but maybe too verbose?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.