0xMiden / 0xMiden/protocol

Introduce an account update size limit at the block level

未關閉
#1,770 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
kernels
主要語言
Rust
星號
132
分支
167
平均合併
1 天 23 小時
30 天內合併 PR
110

描述

As mentioned in https://github.com/0xMiden/miden-node/pull/1140#discussion_r2280650426, we should have a limit in place for account updates per block.

Notably, we already have `ACCOUNT_UPDATE_MAX_SIZE` which is $2^{18}$ currently (and will likely change again with https://github.com/0xMiden/miden-base/issues/1465), but it is only enforced on a transaction level. So with that limit set to 64 KiB, we essentially have a block limit of `ACCOUNT_UPDATE_MAX_SIZE * MAX_ACCOUNTS_PER_BLOCK` = 4 GiB, which is way too much.

The limit for this issue can either be per block globally or per account in a block. The former would allow a block to include a single large account update and many smaller ones, while the latter wouldn't but might be fairer overall.

Given that we already have `ACCOUNT_UPDATE_MAX_SIZE`, maybe a per block maximum might be the most flexible option.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。