Introduce an account update size limit at the block level
- Ngôn ngữ chính
- Rust
- Star
- 132
- Fork
- 167
- Merge trung bình
- 1 ngày 23 giờ
- Pull request đã merge (30 ngày)
- 110
Mô tả
As mentioned in https://github.com/0xMiden/miden-node/pull/1140#discussion_r2280650426, we should have a limit in place for account updates per block.
Notably, we already have `ACCOUNT_UPDATE_MAX_SIZE` which is $2^{18}$ currently (and will likely change again with https://github.com/0xMiden/miden-base/issues/1465), but it is only enforced on a transaction level. So with that limit set to 64 KiB, we essentially have a block limit of `ACCOUNT_UPDATE_MAX_SIZE * MAX_ACCOUNTS_PER_BLOCK` = 4 GiB, which is way too much.
The limit for this issue can either be per block globally or per account in a block. The former would allow a block to include a single large account update and many smaller ones, while the latter wouldn't but might be fairer overall.
Given that we already have `ACCOUNT_UPDATE_MAX_SIZE`, maybe a per block maximum might be the most flexible option.
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.