0xMiden / 0xMiden/protocol

Validate transaction fee in batch

未關閉
#1,689 1 則留言 1 個 reaction 已指派 0 人 在 GitHub 檢視
fees kernels
主要語言
Rust
星號
132
分支
167
平均合併
1 天 23 小時
30 天內合併 PR
110

描述

After the initial fee implementation, the `FEE_ASSET` is essentially completely burned because the batches and blocks don't do anything with it.

While burning is fine for now (until batches and blocks claim the tip part), a batch should validate that a transaction's fees are sufficient by recalculating the required fee for the transaction and checking it against `FEE_ASSET`.

This function can be used for that and should be implemented on both `ExecutedTransaction` and `ProvenTransaction` and not behind `testing`:

https://github.com/0xMiden/miden-base/blob/634d9785914ffb3695042ec72f03ddd469f7f842/crates/miden-objects/src/testing/tx.rs#L5-L11

After this issue, we can consider continuing with validating batch fees in the block, but this issue only covers the above.

Broken out of #1673.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。