0xMiden / 0xMiden/protocol

Validate transaction fee in batch

Offen
#1,689 1 Kommentar 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen
fees kernels
Vorherrschende Sprache
Rust
Sterne
132
Forks
167
Ø Merge
1 T. 23 Std.
Gemergte PRs (30 T.)
110

Beschreibung

After the initial fee implementation, the `FEE_ASSET` is essentially completely burned because the batches and blocks don't do anything with it.

While burning is fine for now (until batches and blocks claim the tip part), a batch should validate that a transaction's fees are sufficient by recalculating the required fee for the transaction and checking it against `FEE_ASSET`.

This function can be used for that and should be implemented on both `ExecutedTransaction` and `ProvenTransaction` and not behind `testing`:

https://github.com/0xMiden/miden-base/blob/634d9785914ffb3695042ec72f03ddd469f7f842/crates/miden-objects/src/testing/tx.rs#L5-L11

After this issue, we can consider continuing with validating batch fees in the block, but this issue only covers the above.

Broken out of #1673.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.