0xMiden / 0xMiden/protocol

Validate transaction fee in batch

Open
#1,689 1 comment 1 reaction 0 assignees View on GitHub
fees kernels
Dominant language
Rust
Stars
132
Forks
167
Avg merge
1d 23h
Merged PRs (30d)
110

Description

After the initial fee implementation, the `FEE_ASSET` is essentially completely burned because the batches and blocks don't do anything with it.

While burning is fine for now (until batches and blocks claim the tip part), a batch should validate that a transaction's fees are sufficient by recalculating the required fee for the transaction and checking it against `FEE_ASSET`.

This function can be used for that and should be implemented on both `ExecutedTransaction` and `ProvenTransaction` and not behind `testing`:

https://github.com/0xMiden/miden-base/blob/634d9785914ffb3695042ec72f03ddd469f7f842/crates/miden-objects/src/testing/tx.rs#L5-L11

After this issue, we can consider continuing with validating batch fees in the block, but this issue only covers the above.

Broken out of #1673.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.