0xMiden / 0xMiden/node

Optimize block num returned on SyncNotes

未關閉
#1,870 3 則留言 1 個 reaction 已指派 0 人 在 GitHub 檢視
store
主要語言
Rust
星號
104
分支
138
平均合併
1 天 13 小時
30 天內合併 PR
56

描述

> There is a small optimization here where we return the block number we dropped, minus one. For example, if we match against blocks 1, 5, 10 and 15 but block 15 does not make it into the response, instead of returning 10 as the last included block, we return 14 (so the next query avoids blocks 10-14 because the user will start at 15 already). I doubt this is significant due to how the tables are probably indexed, so I would not bother doing it unless it's really trivial, but maybe it can be done in a follow up PR or issue

Proposed in https://github.com/0xMiden/node/pull/1843#discussion_r3017955679

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。