0xMiden / 0xMiden/node

Optimize block num returned on SyncNotes

Aberta
#1,870 3 comentários 1 reação 0 responsáveis Ver no GitHub
store
Linguagem predominante
Rust
Estrelas
104
Forks
138
Merge médio
1d 13h
PRs com merge (30d)
56

Descrição

> There is a small optimization here where we return the block number we dropped, minus one. For example, if we match against blocks 1, 5, 10 and 15 but block 15 does not make it into the response, instead of returning 10 as the last included block, we return 14 (so the next query avoids blocks 10-14 because the user will start at 15 already). I doubt this is significant due to how the tables are probably indexed, so I would not bother doing it unless it's really trivial, but maybe it can be done in a follow up PR or issue

Proposed in https://github.com/0xMiden/node/pull/1843#discussion_r3017955679

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.