0xMiden / 0xMiden/node

Add serialized size to structs used in gRPC responses

未關閉
#1,867 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
store
主要語言
Rust
星號
104
分支
138
平均合併
1 天 13 小時
30 天內合併 PR
56

描述

Several endpoints check the number of updates included in the response to stay within `MAX_RESPONSE_PAYLOAD_BYTES` response size. It would be nice to have the serialized size constant associated with the response types to estimate each response size.

This probably requires changes in the protocol first.

> Not for this PR, but it would be good to make this based on the actual serialization sizes. For example, we could have BlockHeader::SERIALIZED_SIZE constant and use it here.
>
> Let's create an issue for this (and include NOTE_RECORD_BYTES in this issue too).

Proposed in: https://github.com/0xMiden/node/pull/1843#discussion_r2998736839

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。