0xMiden / 0xMiden/node

Add serialized size to structs used in gRPC responses

Ouverte
#1,867 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
store
Langage dominant
Rust
Étoiles
104
Forks
138
Merge moyen
1 j 13 h
PR mergées (30 j)
56

Description

Several endpoints check the number of updates included in the response to stay within `MAX_RESPONSE_PAYLOAD_BYTES` response size. It would be nice to have the serialized size constant associated with the response types to estimate each response size.

This probably requires changes in the protocol first.

> Not for this PR, but it would be good to make this based on the actual serialization sizes. For example, we could have BlockHeader::SERIALIZED_SIZE constant and use it here.
>
> Let's create an issue for this (and include NOTE_RECORD_BYTES in this issue too).

Proposed in: https://github.com/0xMiden/node/pull/1843#discussion_r2998736839

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.