0xMiden / 0xMiden/node

Refactor RPC messages to query storage maps by slot ID instead of name

未关闭
#1,444 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
rpc store
主要语言
Rust
星标
104
派生
138
平均合并
1 天 13 小时
30 天内合并 PR
56

描述

A `StorageSlotName` contains both a `String` that uniquely identifies a slot, as well as a `StorageSlotId`, that is derived (hashed) from the name.

It may make sense to change RPC queries to request slots by slot ID instead of slot name, under the assumption that querying by slot ID would be more efficient (should be validated).

I'm not sure if this applies to basically whever we use a `slot_name` in `rpc.proto` or just for requests like `MapEntries` and `StorageMapDetailRequest`.

This then requires changing the DB schema to also index by slot ID and include the slot ID next to the slot name in the `account_storage_map_values` table.

Context:
- https://github.com/0xMiden/miden-node/pull/1440#discussion_r2605465555
- https://github.com/0xMiden/miden-node/pull/1440#discussion_r2605477023

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。