0xMiden / 0xMiden/node

Refactor RPC messages to query storage maps by slot ID instead of name

Aperta
#1,444 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
rpc store
Lingua principale
Rust
Stelle
104
Fork
138
Merge medio
1g 13h
PR unite (30g)
56

Descrizione

A `StorageSlotName` contains both a `String` that uniquely identifies a slot, as well as a `StorageSlotId`, that is derived (hashed) from the name.

It may make sense to change RPC queries to request slots by slot ID instead of slot name, under the assumption that querying by slot ID would be more efficient (should be validated).

I'm not sure if this applies to basically whever we use a `slot_name` in `rpc.proto` or just for requests like `MapEntries` and `StorageMapDetailRequest`.

This then requires changing the DB schema to also index by slot ID and include the slot ID next to the slot name in the `account_storage_map_values` table.

Context:
- https://github.com/0xMiden/miden-node/pull/1440#discussion_r2605465555
- https://github.com/0xMiden/miden-node/pull/1440#discussion_r2605477023

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.