0xMiden / 0xMiden/miden-vm

Document expected error behavior in FRI E2F4 snapshot tests

Open
#2,511 2 comments 0 reactions 0 assignees View on GitHub
documentation on hold tests
Dominant language
Rust
Stars
772
Forks
352
Avg merge
1d 12h
Merged PRs (30d)
93

Description

Several FRI E2F4 test snapshots show `Error: AdapterInnerValueOverflow(...)` in their output, but the tests pass. This is confusing for anyone reviewing the test results.

**Example files:**
- `processor/src/fast/tests/snapshots/*FriE2F4*.snap`

The snapshots show errors like:
```
Error: AdapterInnerValueOverflow(...)
```

These errors are expected when `poe` equals `ZERO`. The tests verify that this error case is handled correctly.

We should add comments to the test code explaining why these errors appear in snapshots and why they're expected. The snapshots themselves are correct.

**References:**
- https://github.com/0xMiden/miden-vm/pull/2472#discussion_r2650455271
- https://github.com/0xMiden/miden-vm/pull/2472#discussion_r2650545946

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.