Refactor decoder handling of control blocks
- 主要语言
- Rust
- 星标
- 772
- 派生
- 352
- 平均合并
- 1 天 12 小时
- 30 天内合并 PR
- 93
描述
When encountering a control block (e.g. `JOIN`), writing to the system and stack columns is [handled by calling `self.execute_op(Operation::Noop)`](https://github.com/0xPolygonMiden/miden-vm/blob/b2294a1e0e98af155d679dce082eb7fe3a04d9a2/processor/src/decoder/mod.rs#L337). This is unintuitive, makes debugging harder (e.g. a print inside `execute_op()` prints a bunch of `NOOP` operations that are not actually in the trace). Also, `DYNCALL` was the first control block where its effect on the stack and system columns doesn't correspond to any existing operation.
The real purpose of "executing NOOPs" is to
1. ensure the trace capacity
2. copy the stack columns over to the next row
3. advance clock
We should introduce an abstraction that does this cleanly instead of reusing `execute_op()`.
Context: https://github.com/0xPolygonMiden/miden-vm/pull/1535#discussion_r1807544164
贡献指南
评估
这个 Issue 还没有评估数据。