0xMiden / 0xMiden/miden-vm

Refactor decoder handling of control blocks

Aberta
#1,538 0 comentários 1 reação 0 responsáveis Ver no GitHub
processor
Linguagem predominante
Rust
Estrelas
772
Forks
352
Merge médio
1d 12h
PRs com merge (30d)
93

Descrição

When encountering a control block (e.g. `JOIN`), writing to the system and stack columns is [handled by calling `self.execute_op(Operation::Noop)`](https://github.com/0xPolygonMiden/miden-vm/blob/b2294a1e0e98af155d679dce082eb7fe3a04d9a2/processor/src/decoder/mod.rs#L337). This is unintuitive, makes debugging harder (e.g. a print inside `execute_op()` prints a bunch of `NOOP` operations that are not actually in the trace). Also, `DYNCALL` was the first control block where its effect on the stack and system columns doesn't correspond to any existing operation.

The real purpose of "executing NOOPs" is to

1. ensure the trace capacity
2. copy the stack columns over to the next row
3. advance clock

We should introduce an abstraction that does this cleanly instead of reusing `execute_op()`.

Context: https://github.com/0xPolygonMiden/miden-vm/pull/1535#discussion_r1807544164

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.