0xMiden / 0xMiden/examples

Benchmarking CLI improvements

未关闭
#39 2 条评论 0 个 reaction 已指派 1 人 已被 @Dominik1999 认领 在 GitHub 查看
good first issue
主要语言
TypeScript
星标
21
派生
28
PR 合并指标
30 天内没有已合并 PR

描述

A few small things that would be great to improve in benchmarking CLI:

1. We should use `structop` instead of `clap` as thats what we use for all other CLIs (e.g., [here](https://github.com/0xPolygonMiden/miden-vm/blob/main/miden/src/main.rs#L13)).
2. We should keep CLI parameters as consistent as possible across different CLIs (e.g., for how we specify security, number of outputs etc.). See example [here](https://github.com/0xPolygonMiden/miden-vm/blob/main/miden/src/cli/prove.rs#L11).
3. Let's change the executable file name to something like `miden-bench` (`miden-benchmarking-cli` is way too long).
4. `miden::prove()` also includes execution time, I believe. So, to make things more clear, we should probably label it as "Execution + proving time" or something like that.
5. Would also be great to print out proof size.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。