0xMiden / 0xMiden/examples

Benchmarking CLI improvements

Abierto
#39 2 comentarios 0 reacciones 1 asignado Reclamado por @Dominik1999 Ver en GitHub
good first issue
Lenguaje dominante
TypeScript
Estrellas
21
Forks
28
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

A few small things that would be great to improve in benchmarking CLI:

1. We should use `structop` instead of `clap` as thats what we use for all other CLIs (e.g., [here](https://github.com/0xPolygonMiden/miden-vm/blob/main/miden/src/main.rs#L13)).
2. We should keep CLI parameters as consistent as possible across different CLIs (e.g., for how we specify security, number of outputs etc.). See example [here](https://github.com/0xPolygonMiden/miden-vm/blob/main/miden/src/cli/prove.rs#L11).
3. Let's change the executable file name to something like `miden-bench` (`miden-benchmarking-cli` is way too long).
4. `miden::prove()` also includes execution time, I believe. So, to make things more clear, we should probably label it as "Execution + proving time" or something like that.
5. Would also be great to print out proof size.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.