0xMiden / 0xMiden/air-script

identify & warn for identical periodic columns

未關閉
#31 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Rust
星號
96
分支
39
PR 合併指標
30 天內沒有已合併 PR

描述

Comment for the future: what should we do if two periodic columns are identical (same cycle length and values)? Should it be an error? A warning? Or something else?

_Originally posted by @bobbinth in https://github.com/0xPolygonMiden/air-dsl/pull/24#discussion_r1003624902_

This should probably be handled as a warning.

We could also consider doing an optimization to identify duplicate periodic columns and always reference the one that was declared first instead, then remove the duplicate from the generated Air. This may be more work than it's worth though, and is lower priority than issuing a warning.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。