0xMiden / 0xMiden/air-script

identify & warn for identical periodic columns

未关闭
#31 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Rust
星标
96
派生
39
PR 合并指标
30 天内没有已合并 PR

描述

Comment for the future: what should we do if two periodic columns are identical (same cycle length and values)? Should it be an error? A warning? Or something else?

_Originally posted by @bobbinth in https://github.com/0xPolygonMiden/air-dsl/pull/24#discussion_r1003624902_

This should probably be handled as a warning.

We could also consider doing an optimization to identify duplicate periodic columns and always reference the one that was declared first instead, then remove the duplicate from the generated Air. This may be more work than it's worth though, and is lower priority than issuing a warning.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。