07th-mod / 07th-mod/python-patcher

Installer does not report out-of-disk-space error if disk space runs out

未关闭
#159 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
JavaScript
星标
214
派生
12
PR 合并指标
30 天内没有已合并 PR

描述

If disk space runs out during the download phase, the installer will report a generic error about the download stage failing, rather than explicitly telling you that disk space ran out (this might also happen during extraction with 7zip). This is mainly because we don't properly parse the output of aria2c to determine the error (even just copying the first line of the error message from aria2c may be better).

The installer should parse the aria2c output to see if disk space ran out, then immediately exit and report out-of-disk space.

TODO:

1. Report less generic error if disk space runs out
2. Stop download/extract immediately if disk space runs out (currently will retry 3 times!)
3. Log disk space on both drives (the target drive and the 'current' drive used for temp files) to installer log (currently neither is logged!)

贡献指南

这个仓库没有索引到贡献指南

调研方向

查看安装程序的下载逻辑,很可能在处理 aria2c 集成的文件中。解析 aria2c 的 stderr 输出以查找磁盘空间错误。更新错误报告以显示特定消息并停止重试。同时,将目标驱动器和临时驱动器的可用空间记录添加到安装程序日志中。通过模拟低磁盘空间进行测试。

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript, python
领域
cli, tooling
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
描述清楚
新手友好度
55/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。