07th-mod / 07th-mod/python-patcher

Installer does not report out-of-disk-space error if disk space runs out

Open
#159 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
214
Forks
12
PR merge metrics
No merged PRs in 30d

Description

If disk space runs out during the download phase, the installer will report a generic error about the download stage failing, rather than explicitly telling you that disk space ran out (this might also happen during extraction with 7zip). This is mainly because we don't properly parse the output of aria2c to determine the error (even just copying the first line of the error message from aria2c may be better).

The installer should parse the aria2c output to see if disk space ran out, then immediately exit and report out-of-disk space.

TODO:

1. Report less generic error if disk space runs out
2. Stop download/extract immediately if disk space runs out (currently will retry 3 times!)
3. Log disk space on both drives (the target drive and the 'current' drive used for temp files) to installer log (currently neither is logged!)

Contributor guide

No contributing guide indexed for this repository

Research direction

Look at the installer's download logic, likely in a file handling aria2c integration. Parse aria2c's stderr output for disk space errors. Update error reporting to show a specific message and stop retries. Also add logging of free space for the target and temp drives to the installer log. Test by simulating low disk space.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, python
Domain
cli, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.