Don't rely on reprocessing of targets with errors in fine grained mode

未关闭
#4,801 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
25/100
Issue 类型
重构
描述清晰度
基本清楚
活跃度
停滞
技术栈
python

调研方向

Start by running the [case testWarnUnusedIgnoresFine] scenario with --warn-unused-ignores and confirm the current failure. Trace how fine-grained mode handles targets with errors and reprocessing, then determine how dependency tracking or cached errors should make the case pass without relying on reprocessing.

由索引模型根据 Issue 内容生成。

描述

needs discussion topic-fine-grained-incremental

Consider this test case:

[case testWarnUnusedIgnoresFine]
# flags: --warn-unused-ignores
import a
[file a.py]
import b
b.x  # type: ignore
[file b.py]
# empty
[file b.py.2]
x = 1
[out]
==
a.py:2: note: unused 'type: ignore' comment

Currently it fails, presumably because we don't reprocess a.py. This however points to a larger potential problem, currently we are relying on reprocessing targets with errors. However, a better idea might be to only rely on fine grained dependencies. Of course, we can cache errors and just show them if a target had errors and was not reprocessed.

主要语言
Python
星标
20.6k
派生
3.3k
平均合并
1 天 18 小时
30 天内合并 PR
54

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

python/mypy 的其他 Issue

查看 python/mypy 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。