Type refinement does not work with `None in [a, b, c]`, `any()`, or `all()` checks

未关闭
#17,149 2 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
35/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
停滞
技术栈
python
领域
compilers

调研方向

从 None 成员检查和 all() 检查的复现示例开始,然后跟踪 mypy 对这些条件表达式的类型细化处理。完成的标准是:检查之后,报告的变量从 Optional[str] 和 Optional[int] 被收窄,并且不再出现所示错误。

由索引模型根据 Issue 内容生成。

描述

bug topic-type-narrowing

When checking if multiple variables are not None using the syntax None in [a, b, c], mypy fails to refine the types of these variables to non-Optional types after this check. This issue persists even when using any() or all() for similar checks, preventing mypy from correctly inferring that the variables cannot be None past these checks, despite the code logically ensuring that these variables are not None.

Code to Reproduce:

from typing import Optional

def init_vars(
    a: Optional[str] = None,
    b: Optional[int] = None,
    c: Optional[int] = None,
) -> None:
    if None in [a, b, c]:
        raise ValueError("a, b, and c cannot be None")
    
    # Expected: a, b, c should not be Optional types beyond this point
    # Actual: mypy still treats a, b, c as Optional types
    print(a.upper())  # mypy error: Item "None" of "Optional[str]" has no attribute "upper"
    print(b + 1)      # mypy error: Unsupported operand type(s) for +: 'int' and 'NoneType'
    print(c + 1)      # mypy error: Unsupported operand type(s) for +: 'int' and 'NoneType'

And here is another example with the all function (with any it is quite similar):

def init_vars_with_all(
    a: Optional[str] = None,
    b: Optional[int] = None,
    c: Optional[int] = None,
) -> None:
    if not all(x is not None for x in [a, b, c]):
        raise ValueError("a, b, and c cannot be None")

    # Expected: a, b, c should not be Optional types beyond this point
    # Actual: mypy still treats a, b, c as Optional types
    print(a.upper())  # mypy error: same as above
    print(b + 1)      # mypy error: same as above
    print(c + 1)      # mypy error: same as above
Expected Behavior:

After the checks if None in [a, b, c]: or using all(), mypy should refine the types of a, b, and c to str, int, and int respectively, acknowledging that they cannot be None.

Actual Behavior:

mypy does not refine the types and continues to treat a, b, and c as Optional[str], Optional[int], and Optional[int] respectively. This results in type errors when attempting to use these variables in a context that does not allow None.

Additional Information:

mypy version: 1.9.0 compiled
Python version: 3.10
No flags or configurations are altering the default behavior of mypy in this instance.

This behavior suggests a limitation in mypy's type inference system when it comes to using collective None checks with list membership or aggregate functions like any() and all(). An enhancement to allow type refinement in such cases would significantly improve usability in scenarios involving initialization checks for multiple variables.

主要语言
Python
星标
20.6k
派生
3.3k
平均合并
1 天 18 小时
30 天内合并 PR
54

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

python/mypy 的其他 Issue

查看 python/mypy 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。