The tarfile module crashes when tarfile contains a symlink and unpack directory contain it too

未关闭
#67,417 9 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
python
领域
tooling

调研方向

Start with tarfile-extract-crash.py to reproduce the symlink collision, then inspect the tarfile module and the possible-fix-23228-with-test2.diff attachment. Compare the existing fix attempts and their test changes; done means the crash is prevented and the regression case passes, including the Windows-specific case in windowserror.diff.

由索引模型根据 Issue 内容生成。

描述

stdlib type-bug
BPO 23228
Nosy @warsaw, @gustaebel, @vadmium, @serhiy-storchaka
Files
  • tarfile-extract-crash.py
  • possible-fix-37688.diff
  • possible-fix-23228-with-test.diff
  • possible-fix-23228-with-test2.diff
  • windowserror.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2015-01-13.08:55:02.134>
    labels = ['type-bug', 'library']
    title = 'The tarfile module crashes when tarfile contains a symlink and unpack directory contain it too'
    updated_at = <Date 2018-12-16.01:34:29.727>
    user = 'https://bugs.python.org/mvo'
    

    bugs.python.org fields:

    activity = <Date 2018-12-16.01:34:29.727>
    actor = 'martin.panter'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2015-01-13.08:55:02.134>
    creator = 'mvo'
    dependencies = []
    files = ['37688', '37689', '37690', '37774', '42780']
    hgrepos = []
    issue_num = 23228
    keywords = ['patch']
    message_count = 9.0
    messages = ['233907', '233910', '233914', '233918', '234309', '264808', '265146', '265147', '331911']
    nosy_count = 6.0
    nosy_names = ['barry', 'lars.gustaebel', 'mvo', 'SilentGhost', 'martin.panter', 'serhiy.storchaka']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue23228'
    versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']
    

    主要语言
    Python
    星标
    77.2k
    派生
    36k
    平均合并
    1 天 9 小时
    30 天内合并 PR
    558

    贡献指南

    打开贡献指南

    从这里开始

    1. 先读完整个 Issue,再读项目的贡献指南。
    2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
    3. Fork 仓库,在一个分支上完成修改。
    4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

    python/cpython 的其他 Issue

    查看 python/cpython 的全部 Issue

    相似的 Issue

    更多 Python Issue

    把新 issue 发到你的邮箱

    精选适合新手参与的 GitHub issue 摘要。