remove bootstrap dependency
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 35/100
- Issue 类型
- 重构
- 描述清晰度
- 需要澄清
- 活跃度
- 冷清
- 技术栈
- bootstrap, javascript
- 领域
- frontend
调研方向
在仓库中搜索 bootstrap@4 依赖及其图标使用位置,然后检查 SolidOS 图标目录和链接的图标讨论,以寻找可能的替代方案。完成的标准是移除 Bootstrap 且不留下图标引用,并且替代方案已达成一致并经过验证。
由索引模型根据 Issue 内容生成。
描述
NSS only use bootstrap icons. We may use SolidOS icons
We use bootstrap@4 latest open source license. This version has a vulnerability
Wednesday
* Noel De Martin
I use icons like this https://icones.js.org/
* Noel De Martin
So basically I look for the icons I want to use in that website, and then in my code I just write the <i- element (I don't have to import any library or anything), then when the app is built the SVGs are auto-replaced :)
Here's an example of using that in Umai: https://github.com/NoelDeMartin/umai/blob/a0d2887e8f70d93ee6f3b3d33b39452cea5874c9/src/components/AppHeaderUserMenu.vue#L18
and regarding colors, they use fillCurrent by default, so they'll have the same color as the text. It can also be overriden by setting the text color with CSS
* Tim Berners-Lee
Our icons are mostly from https://thenounproject.com/
* Noel De Martin
I see, it seems like most of them are plain SVGs (not part of any icon set). You can also add custom SVGs using this, for example I have a few here: https://github.com/NoelDeMartin/umai/tree/main/src/assets/icons
I'll see if I can integrate something like this in SolidOS :). It's also better to use icons from an icon set in order to keep a consistent visual identity, grabbing random SVGs from websites can create some UI inconsistencies
* Timea
this is because Sharon downloaded them from the new design.
I could ask the designer if they use some icon Library....
at the top of the meeting minutes find a link to a ticket where our current designs are. it's all figma.
* Tim Berners-Lee
I don't see why NounProject is not considered an icon set .. it has too many alternatives?
* Tim Berners-Lee
The icons are in https://github.com/SolidOS/solid-ui/tree/main/src/icons ... so we use consistent icons across SolidOS and also apps.
* Noel De Martin
* Tim Berners-Lee
I don't see why NounProject is not considered an icon set .. it has too many alternatives?
yeah, it's not an icon set, it's just a marketplace where anyone can upload their SVGs. Icon sets usually have a consistent style, etc. It's like using a font family, you can use as many font families as you want in a website, but it's usually better to choose a couple that look well together.
* Timea
it's just about the designers choice and the look of them.i can see what they say.
- 主要语言
- JavaScript
- 星标
- 1.8k
- 派生
- 308
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
nodeSolidServer/node-solid-server 的其他 Issue
-
难度 1/5 1 小时以内 新手友好度 72/100
nodeSolidServer/node-solid-server#1848 · 2 条评论 · 1 个 reaction ·
-
难度 2/5 1-3 小时 新手友好度 65/100
nodeSolidServer/node-solid-server#1841 · 2 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 65/100
nodeSolidServer/node-solid-server#1147 ·
-
难度 5/5 一周以上 新手友好度 45/100
nodeSolidServer/node-solid-server#1853 ·
-
难度 3/5 1-2 天 新手友好度 62/100
nodeSolidServer/node-solid-server#1852 · 1 条评论 ·
查看 nodeSolidServer/node-solid-server 的全部 Issue
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 76/100
avniproject/avni-client#2135 ·
-
enhancement
难度 2/5 1-3 小时 新手友好度 70/100
babalae/bettergi-scripts-list#3674 ·
-
A-Release-Notes C-Editing D-Modest S-Ready-For-Implementation
难度 2/5 1-3 小时 新手友好度 72/100
bevyengine/bevy-website#2595 ·
-
ecosystem wording
难度 1/5 1 小时以内 新手友好度 90/100
matrix-org/matrix.org#3649 ·
-
难度 2/5 1-3 小时 新手友好度 88/100
vadimdemedes/ink#1029 ·