Allow `.js` file generated from `.tsx` file to be runnable in browser with less configuration
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 35/100
- Issue 类型
- 功能
- 描述清晰度
- 描述清楚
- 活跃度
- 停滞
- 技术栈
- javascript, typescript
调研方向
使用所示的 tsconfig.json 以及 Foo.tsx、subfolder/Bar.tsx 和 myCustomJSX/jsx-dev-runtime.ts 布局重现该问题。先从 tsc 的 JSX 导入生成和模块解析行为入手,然后验证生成的导入是否为两个输出文件都包含 .js 扩展名和正确的相对路径。
由索引模型根据 Issue 内容生成。
描述
🔍 Search Terms
- jsx-dev-runtime.js
- jsx-runtime.js
✅ Viability Checklist
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
- This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals
⭐ Suggestion
The .js file generated from .tsx file should have file extension in the injected import statement.
Also, if the value of jsxImportSource is relative (for e.g. ./myCustomJSX instead of myCustomJSX), the import statement should have correct relative path to JSX runtime files.
📃 Motivating Example
Suppose, a web project has following files and folders:
/tsconfig.json/myCustomJSX/jsx-dev-runtime.ts/Foo.tsx/subfolder/Bar.tsx/index.html
And, tsconfig.json looks like:
{
"compilerOptions": {
"jsx": "react-jsxdev",
"jsxImportSource": "./myCustomJSX",
}
}
After running npx tsc, all generated .js files (/Foo.js, /subfolder/Bar.js) have following code at the top:
import { jsxDEV as _jsxDEV, Fragment as _Fragment } from "./myCustomJSX/jsx-dev-runtime";
There are three problems with this:
- The
.jsextension is missing in the import statement. - The path of the module is not accurate for
/subfolder/Bar.js - Also,
tscshows following error for/subfolder/Bar.tsx:subfolder/Bar.tsx:13:3 - error TS2307: Cannot find module './myCustomJSX/jsx-dev-runtime' or its corresponding type declarations.
Expected behavior:
/Foo.js:
import { jsxDEV as _jsxDEV, Fragment as _Fragment } from "./myCustomJSX/jsx-dev-runtime.js";
/subfolder/Bar.js:
import { jsxDEV as _jsxDEV, Fragment as _Fragment } from "../myCustomJSX/jsx-dev-runtime.js";
💻 Use Cases
-
What do you want to use this for?
I want to use this for web project that utilizes JSX syntax and uses only TypeScript as build tool. -
What shortcomings exist with current approaches?
The current approach requires too much extra steps when using the generated.jsfile in web project without additional build steps, especially when using relative path injsxImportSource. -
What workarounds are you using in the meantime?
I am providing following inimportmapin/index.htmlfile:<script type="importmap"> { "imports": { "./myCustomJSX/jsx-dev-runtime": "./myCustomJSX/jsx-dev-runtime.js" "./subfolder/myCustomJSX/jsx-dev-runtime": "./myCustomJSX/jsx-dev-runtime.js" } } </script>However, the importmap can grow when there are
.tsxfiles in many depths in file system.
If this issue is solved, there won't be any need for importmap when using relative path injsxImportSource. However, for bare module path, 1 entry in importmap is still required.
- 主要语言
- Go
- 星标
- 111k
- 派生
- 14.4k
- 平均合并
- 1 天 15 小时
- 30 天内合并 PR
- 106
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
microsoft/TypeScript 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 88/100
microsoft/TypeScript#64322 · 2 条评论 · 1 个 reaction · 已指派 2 人 ·
-
Possible Improvement
难度 2/5 1-3 小时 新手友好度 78/100
microsoft/TypeScript#64278 · 1 条评论 · 1 个 reaction ·
-
Docs
难度 2/5 1-3 小时 新手友好度 70/100
microsoft/TypeScript#64118 · 1 条评论 ·
-
难度 1/5 1 小时以内 新手友好度 88/100
microsoft/TypeScript#64094 ·
-
Docs
难度 2/5 1-3 小时 新手友好度 76/100
microsoft/TypeScript#63959 · 5 条评论 ·
查看 microsoft/TypeScript 的全部 Issue
相似的 Issue
-
Type/Bug
难度 2/5 1-3 小时 新手友好度 78/100
OpenNSW/nsw-srilanka#497 ·
-
难度 1/5 1 小时以内 新手友好度 92/100
milvus-io/birdwatcher#545 ·
-
kind/bug
难度 2/5 1-3 小时 新手友好度 88/100
kubernetes-sigs/prow#953 · 1 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 88/100
-
难度 2/5 1-3 小时 新手友好度 88/100
caddyserver/caddy#8046 ·