infinite generator transform is no longer infinite

未关闭
#56,363 1 条评论 1 个 reaction 已指派 1 人 在 GitHub 查看

@rbuckton 已经在做这个了。

开始于 2023年11月10日。

评估

这个 Issue 还没有评估数据。

描述

Needs Investigation
🔎 Search Terms

A function returning 'never' cannot have a reachable end point.

🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about never and generator.

⏯ Playground Link

https://www.typescriptlang.org/play?#code/GYVwdgxgLglg9mAVAAggTwgGwKYB4AqAfABQxTYBOAhgEY4BcyAkudXXkQJSMDi2YlKlDgUCAGmQCAbpQngAJtmAwB8wsgDeAKGTIA7gAsYOZMSgUQ2TsjQxsmeSjKD2Abi0BfLVtCRYCFGwADyoAWwAHHDNgqEYAZ3MVAHNuZD4BamFRAFoARmQAH2RciWlKdW1dYBFTCAQE1AMqCmQ4YFQMKIBBCmo0ADpgCjhQ6KCoTkmbOwdG5uQAXiXkACJcFeQAfmQ85EZc9w8gA

💻 Code
function* cycle<T>(iterable: Iterable<T>): Generator<T, never, undefined> {
  while (true) yield* iterable;
}

function* example(text: string): Generator<-1 | 1, never> {
  for (const char of cycle(Array.from(text))) yield char === "<" ? -1 : 1;
}
🙁 Actual behavior

The second generator function build on top of the first where consumers of cycle do not need to check IteratorResult#done as the never return type is interpreted as never done. This is great for direct callers of cycle() but other generator functions building on top of cycle() are not inferred too as having a return type of never.

🙂 Expected behavior

A loop over an infinite generator (i.e. one with a return type of never) is also inferred as an infinite loop.

Additional information about the issue

A throw statement can be added after the loop as a workaround but I think this shouldn't be necessary:

function* example(text: string): Generator<-1 | 1, never> {
  for (const char of cycle(Array.from(text))) yield char === "<" ? -1 : 1;
  throw new Error("unreachable");
}
主要语言
Go
星标
111k
派生
14.4k
平均合并
1 天 19 小时
30 天内合并 PR
117

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

microsoft/TypeScript 的其他 Issue

查看 microsoft/TypeScript 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。