Allow trailing lines in multiline comment directives

未关闭
#38,370 4 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

@DanielRosenwasser 已经在做这个了。

开始于 2020年5月8日。

评估

这个 Issue 还没有评估数据。

描述

Bug Domain: Parser Rescheduled

TypeScript Version: 4.0.0-dev.20200507

Search Terms: multiline comment directive ts-expect-error ts-ignore

Code

const x = 0;

/* @ts-ignore
continuing comment 
 that could be multiline*/

x();

Expected behavior:

The comment looks like a directive to ignore the x();'s type checking complaint.

Actual behavior:

Comment directive parsing only looks at the last line of the comment. It should also allow the first line of the comment.

I'm in favor of not allowing any other lines (i.e. "middle" lines) to count as directives. Extending to allow characters after the @ts- has precedent from what's already allowed (we're really just adding newlines). But putting characters before the @ts- has a precedent of not working even in single-line comments.

/* Here we use a
@ts-ignore
 that is multiline*/

Playground Link: https://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=28&pc=2#code/MYewdgzgLgBAHjAvDADAbgFAYPQCoYACUEAtAJYDmYIATgKYahhRlgCurFMoAtj3cxgYYUABYBDWKDYAbACYwARnRg9ZLGazq5sWOAAoAlGiA

Related Issues: Following discussion in https://github.com/microsoft/TypeScript/pull/38228#discussion_r420940329, as suggested by @sheetalkamat.

主要语言
Go
星标
111k
派生
14.4k
平均合并
1 天 19 小时
30 天内合并 PR
117

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

microsoft/TypeScript 的其他 Issue

查看 microsoft/TypeScript 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。