Descriptor Protocol

未关闭
#825 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
25/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
停滞
技术栈
javascript, python
领域
compilers

调研方向

Start with the proposed py_metatype.new override and its surrounding pragma('js') block in the issue. The payload names no repository file or test, so locating the compiler/runtime integration and defining coverage for the listed descriptor limitations will require project familiarity. Done means descriptor access and assignment work as described without breaking existing behavior.

由索引模型根据 Issue 内容生成。

描述

This is a little bit of a patch (hack) I apply to allow the use of the descriptor protocol (or, most of it). Descriptors are really useful for reactive UI design, and easy to implement in a way that shares sensibilities with Transcrypt's implementation of properties. The readme suggested I start by raising the idea as an issue, so I didn't bother reworking it as a pull request that modifies the code-base directly. Hope this is interesting and doesn't wreck anything fundemental.

"""
Add the descriptor protocol to `py_metatype`.
Limitations:
  - `__delete__` is not supported.
  - Assigning a new value to an attribute that is a set operation on a class
    will not replace the descriptor (much like Transcrypt's `@property`).
  - Cannot access descriptor instance using `vars` (`vars` is not supported).
  - Missing `__get__` or `__set__` are noop (much like Transcrypt's
    `@property`).
"""
__pragma__('js', '{}', '''
(function(undefined) {

    function _get_function(descriptor) {
        return function() {
            if(this.hasOwnProperty('__class__')) {
                return descriptor.__get__(this, py_typeof(this))
            } else {
                return descriptor.__get__(null, this)
            }
        };
    }
    
    function _set_function(descriptor) {
        return function(value) {
            if(this.hasOwnProperty('__class__')) {
                descriptor.__set__(this, value);
            }
        };
    }
    
    const _py_metatype_new = py_metatype.__new__;

    py_metatype.__new__ = function (meta, name, bases, attributes) {
        const new_type = _py_metatype_new(meta, name, bases, attributes);
        for(const attribute in attributes) {
            const descriptor = new_type[attribute];
            if(
                descriptor &&
                descriptor.hasOwnProperty('__class__') &&
                (descriptor.__get__ || descriptor.__set__)
            ) {
                const data = { enumerable: true };
                if(descriptor.__get__) {
                    data.get = _get_function(descriptor);
                }
                if(descriptor.__set__) {
                    data.set = _set_function(descriptor);
                }
                Object.defineProperty(new_type, attribute, data);
                if(descriptor.__set_name__) {
                    descriptor.__set_name__(new_type, attribute);
                }
            }
        }
        return new_type;
    };

})();
''')
主要语言
Python
星标
2.9k
派生
218
PR 合并指标
30 天内没有已合并 PR

贡献指南

这个仓库没有索引到贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TranscryptOrg/Transcrypt 的其他 Issue

查看 TranscryptOrg/Transcrypt 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。