@property causes errors due to incorrect generated code
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 35/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- javascript, python
- 领域
- compilers
调研方向
Reproduce the MWE and inspect the generated props.js output alongside the get implementation shown in the issue. Trace the generated Foo property definitions and property access, then verify that both properties reference the correct implementation functions and return values rather than attempting to call them.
由索引模型根据 Issue 内容生成。
描述
MWE:
class Foo:
@property
def bar(self):
return 'Hello World'
@property
def name(self):
return 'John Smith'
foo = Foo()
print(foo.bar) # Should print "Hello World"
print(foo.name) # Should print "John Smith"
The relevant Transcrypt output is:
var Foo = __class__ ('Foo', 'props', [object], {
__impl__bar: function (self) {
return 'Hello World';
},
get bar () {return __get__ (this, this.__impl__bar);},
__impl__name: function (self) {
return 'John Smith';
},
get py_name () {return __get__ (this, this.__impl__name);}
})
Object.defineProperty (Foo, '__impl__bar', property.call (Foo, Foo.Foo.__impl__bar));;
Object.defineProperty (Foo, '__impl__name', property.call (Foo, Foo.Foo.__implpy_name));;;
Note that __impl__bar is defined as Foo.__impl__bar, but is referenced in the defineProperty call as Foo.Foo.__impl__bar. This causes an error, as Foo.Foo is undefined:
.../props.js:2450
Object.defineProperty (Foo, '__impl__bar', property.call (Foo, Foo.Foo.__impl__bar));;
^
TypeError: Cannot read property '__impl__bar' of undefined
A simple workaround is to patch the output: perl -0777 -pi -e 's/property.call \((.*?), \g1.\g1.__impl__(.*?)\)/property.call ($1, $1.__impl__$2)/g' path/to/file.js
Note that for Foo.name, there is a slightly different problem as well, in that the function is defined as __impl__name, but is referenced as __implpy_name, causing a further error.
Again, a simple workaround suffices for now: perl -0777 -pi -e 's/property.call \((.*?), \g1.\g1.__implpy_(.*?)\)/property.call ($1, $1.__impl__$2)/g' path/to/file.js
Even after applying these patches however, @property is still not functional because e.g. foo.bar ends up being wrapped as a function that attempts to "call" foo.bar. This, of course, fails, because foo.bar is not a function.
The issue appears to be in the implementation __get__:
var __get__ = function (self, func, quotedFuncName) {
if (self) {
if (self.hasOwnProperty ('__class__') || typeof self == 'string' || self instanceof String) { // Object before the dot
if (quotedFuncName) { // Memoize call since fcall is on, by installing bound function in instance
// ...
// The property is defined as a function instead of a value
Inserting a statement if(typeof(func) != "function"){return func;} at the very beginning of this function seems to fix the issue.
- 主要语言
- Python
- 星标
- 2.9k
- 派生
- 218
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
TranscryptOrg/Transcrypt 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 84/100
TranscryptOrg/Transcrypt#913 ·
-
难度 2/5 1-3 小时 新手友好度 88/100
TranscryptOrg/Transcrypt#911 · 2 条评论 ·
-
IS: bug
难度 2/5 1-3 小时 新手友好度 70/100
TranscryptOrg/Transcrypt#908 ·
-
SUB: documentation
难度 1/5 1 小时以内 新手友好度 62/100
TranscryptOrg/Transcrypt#656 · 7 条评论 ·
-
难度 3/5 1-2 天 新手友好度 76/100
TranscryptOrg/Transcrypt#914 ·
查看 TranscryptOrg/Transcrypt 的全部 Issue
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 86/100
zostera/django-bootstrap4#894 ·
-
难度 2/5 1-3 小时 新手友好度 78/100
use-agent-os/agent-os#3276 ·
-
难度 2/5 1-3 小时 新手友好度 88/100
zephyrproject-rtos/zephyr#119726 ·
-
area/auth bug comp/agent P3 platform/discord type/security
难度 2/5 1-3 小时 新手友好度 88/100
NousResearch/hermes-agent#117848 ·
-
难度 2/5 1-3 小时 新手友好度 82/100
zilliztech/memsearch#759 ·