@property causes errors due to incorrect generated code

未关闭
#407 5 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
javascript, python
领域
compilers

调研方向

Reproduce the MWE and inspect the generated props.js output alongside the get implementation shown in the issue. Trace the generated Foo property definitions and property access, then verify that both properties reference the correct implementation functions and return values rather than attempting to call them.

由索引模型根据 Issue 内容生成。

描述

IS: exploratory IS: limitation

MWE:

class Foo:
	@property
	def bar(self):
		return 'Hello World'
	
	@property
	def name(self):
		return 'John Smith'

foo = Foo()

print(foo.bar) # Should print "Hello World"
print(foo.name) # Should print "John Smith"

The relevant Transcrypt output is:

var Foo = __class__ ('Foo', 'props', [object], {
	__impl__bar: function (self) {
		return 'Hello World';
	},
	get bar () {return __get__ (this, this.__impl__bar);},
	__impl__name: function (self) {
		return 'John Smith';
	},
	get py_name () {return __get__ (this, this.__impl__name);}
})
Object.defineProperty (Foo, '__impl__bar', property.call (Foo, Foo.Foo.__impl__bar));;
Object.defineProperty (Foo, '__impl__name', property.call (Foo, Foo.Foo.__implpy_name));;;

Note that __impl__bar is defined as Foo.__impl__bar, but is referenced in the defineProperty call as Foo.Foo.__impl__bar. This causes an error, as Foo.Foo is undefined:

.../props.js:2450
                Object.defineProperty (Foo, '__impl__bar', property.call (Foo, Foo.Foo.__impl__bar));;
                                                                                       ^

TypeError: Cannot read property '__impl__bar' of undefined

A simple workaround is to patch the output: perl -0777 -pi -e 's/property.call \((.*?), \g1.\g1.__impl__(.*?)\)/property.call ($1, $1.__impl__$2)/g' path/to/file.js

Note that for Foo.name, there is a slightly different problem as well, in that the function is defined as __impl__name, but is referenced as __implpy_name, causing a further error.

Again, a simple workaround suffices for now: perl -0777 -pi -e 's/property.call \((.*?), \g1.\g1.__implpy_(.*?)\)/property.call ($1, $1.__impl__$2)/g' path/to/file.js

Even after applying these patches however, @property is still not functional because e.g. foo.bar ends up being wrapped as a function that attempts to "call" foo.bar. This, of course, fails, because foo.bar is not a function.

The issue appears to be in the implementation __get__:

var __get__ = function (self, func, quotedFuncName) {
	if (self) {
		if (self.hasOwnProperty ('__class__') || typeof self == 'string' || self instanceof String) {           // Object before the dot
			if (quotedFuncName) {                                   // Memoize call since fcall is on, by installing bound function in instance
				// ...
				// The property is defined as a function instead of a value

Inserting a statement if(typeof(func) != "function"){return func;} at the very beginning of this function seems to fix the issue.

主要语言
Python
星标
2.9k
派生
218
PR 合并指标
30 天内没有已合并 PR

贡献指南

这个仓库没有索引到贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TranscryptOrg/Transcrypt 的其他 Issue

查看 TranscryptOrg/Transcrypt 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。