Possible change / correction of Field export affecting four packages
还没有人认领这个 Issue。
评估
调研方向
Review the existing field-exporter fix behind its #define and the before/after reverse-depends results described in the issue. Investigate the remaining failures in carat and perccal, then clarify the compatible API behavior, fallback requirements, and timeline before implementation.
由索引模型根据 Issue 内容生成。
描述
Issue https://github.com/RcppCore/RcppArmadillo/issues/263, opened quite some time ago by @coatless, demonstrated that we had a bug stacked away in dealing with a field exporter which dropped a dimension. I worked a bit on that in November and committed a fix albeit behind a #define. I had meant to come back to this and had time last week to run two sets of 'before' and 'after' reverse-depends checks to assess how costly it would be to enable this unconditionally.
It turns out that four (out of 950 total (!!)) packages then fail tests:
- AlphaSimR by @gaynorr et al -- already addressed in version 1.1.2 on CRAN
- carat by @yexiaoqingruc et al
- odpc by @esmucler -- will revert to old behavior, see #3, #4, addressed in version 2.0.5 on CRAN
- perccal by Dan McCarthy (not on GH, emailed 2022-02-13)
I have not yet had time to look into patches or changes. We probably want to fix this, and worst case can offer a #define to allow these four packages (and other uses like them) to get the old behavior back (in the sense of 'we published an API so we need to honor that contract') but otherwise offer 'better' code.
So "just" opening this issue to see if we can start a dialogue about what would be a suitable timeline to make the change. Maybe in three months? Too soon?
- 主要语言
- C++
- 星标
- 211
- 派生
- 54
- 平均合并
- 5 分钟
- 30 天内合并 PR
- 1
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
RcppCore/RcppArmadillo 的其他 Issue
-
难度 5/5 一周以上 新手友好度 25/100
RcppCore/RcppArmadillo#454 · 3 条评论 ·
-
难度 4/5 3-5 天 新手友好度 35/100
RcppCore/RcppArmadillo#299 · 6 条评论 ·
-
难度 4/5 3-5 天 新手友好度 20/100
RcppCore/RcppArmadillo#268 · 3 个 reaction ·
-
enhancement help wanted
难度 4/5 3-5 天 新手友好度 35/100
RcppCore/RcppArmadillo#263 · 3 条评论 · 2 个 reaction ·
-
enhancement help wanted
难度 4/5 3-5 天 新手友好度 35/100
RcppCore/RcppArmadillo#250 · 1 条评论 ·
查看 RcppCore/RcppArmadillo 的全部 Issue
相似的 Issue
-
[BUG] 未关闭bug
难度 2/5 1-3 小时 新手友好度 85/100
eunomia-bpf/llvmbpf#51 · 1 条评论 ·
-
status:needs-triage
难度 2/5 1-3 小时 新手友好度 78/100
PX4/PX4-Autopilot#28776 ·
-
Website Doc Typo 未关闭
难度 1/5 1 小时以内 新手友好度 92/100
-
难度 1/5 1-3 小时 新手友好度 92/100
autowarefoundation/autoware_universe#13413 ·
-
难度 2/5 1-3 小时 新手友好度 88/100