Punishment Curse Should Be Automatically Calculated in DPS

未关闭
#10,215 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
55/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
冷清
技术栈
lua
领域
game-dev, tooling

调研方向

首先定位 DPS 计算中的 Punishment modifier 和现有的“Enemy is on Low Life”复选框，然后将该处理路径与 Culling Strike 的自动处理进行比较。完成的标准是：Punishment 自动贡献其低生命值增伤的一半，并在复选框启用时使用完整数值，同时相关测试覆盖该计算。

由索引模型根据 Issue 内容生成。

描述

enhancement
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

Punishment curse does not contribute to the final DPS unless the "Enemy is on Low Life" checkbox is checked. This behavior is inconsistent in PoB compared to effects like Culling Strike.

Describe the solution you'd like

I think the increased damage taken at half its value should be applied automatically.

For example, Culling Strike is calculated automatically in the final DPS. It does not require an "Enemy is in Culling Strike range" checkbox.

This should be especially easy now that Low Life is 50%. For example, if a player has level 1 Punishment that says:

"Cursed Enemies take 30% increased Damage while on Low Life"

It could automatically be calculated as:

"Nearby Enemies take 15% increased Damage"

Then, if the player checks the "Enemy is on Low Life" checkbox, it could use the original 30% value instead.

Please consider this change, and thanks a lot for all your hard work!

Describe alternatives you've considered

No response

Additional context

No response

主要语言
Lua
星标
5.4k
派生
2.4k
平均合并
1 天 12 小时
30 天内合并 PR
26

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

PathOfBuildingCommunity/PathOfBuilding 的其他 Issue

查看 PathOfBuildingCommunity/PathOfBuilding 的全部 Issue

相似的 Issue

更多 Lua Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。