unable to build w/o specifying rails version in ENV

未关闭
#1,415 0 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
停滞
技术栈
rails, ruby

调研方向

阅读 Gemfile 第 26 行和 test/test_helper.rb 第 26 行,然后在不设置 RAILS_VERSION 的情况下,使用 README 中的 bundle install 和测试命令重现失败。检查 Rails 依赖项解析,并验证干净的 checkout 可以安装依赖项并运行测试套件,而不需要该环境变量。

由索引模型根据 Issue 内容生成。

描述

This issue is a (choose one):

  • [X ] Problem/bug report.
  • Feature request.
  • Request for support. Note: Please try to avoid submitting issues for support requests. Use Gitter instead.

Checklist before submitting:

  • [ X] I've searched for an existing issue.
  • [ X] I've asked my question on Gitter and have not received a satisfactory answer.
  • [ N/A] I've included a complete bug report template. This step helps us and allows us to see the bug without trying to reproduce the problem from your description. It helps you because you will frequently detect if it's a problem specific to your project.
  • [ N/A] The feature I'm asking for is compliant with the JSON:API spec.

Description

Bug reports:

Upon checking out this project you cannot successfully run the test suite following the instructions in the README.

running bundle install at this moment will resolve railties-7.1.1 as a dependency. this will cause https://github.com/cerebris/jsonapi-resources/blob/0ba80a1ef6a7b4dbea3097b207380979336e9376/test/test_helper.rb#L26 to fail with something like:

/Users/knagelberg/.asdf/installs/ruby/3.2.0/lib/ruby/gems/3.2.0/gems/railties-7.1.1/lib/rails.rb:51:in `configuration': undefined method `config' for nil:NilClass (NoMethodError)

      application.config
                 ^^^^^^^
        from /Users/knagelberg/.asdf/installs/ruby/3.2.0/lib/ruby/gems/3.2.0/gems/railties-7.1.1/lib/rails/testing/maintain_test_schema.rb:11:in `<top (required)>'
        from <internal:/Users/knagelberg/.asdf/installs/ruby/3.2.0/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
        from <internal:/Users/knagelberg/.asdf/installs/ruby/3.2.0/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
        from /Users/knagelberg/.asdf/installs/ruby/3.2.0/lib/ruby/gems/3.2.0/gems/railties-7.1.1/lib/rails/test_help.rb:17:in `<top (required)>'
        from <internal:/Users/knagelberg/.asdf/installs/ruby/3.2.0/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
        from <internal:/Users/knagelberg/.asdf/installs/ruby/3.2.0/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
        from /Users/knagelberg/codes/jsonapi-resources/test/test_helper.rb:26:in `<top (required)>'

setting RAILS_VERSION as suggested in the project:
export RAILS_VERSION=6.1.1; bundle update; bundle exec rake test
solves this problem. perhaps adjusting https://github.com/cerebris/jsonapi-resources/blob/864e810cb96e09f40f4c57db27445d1ef74c6554/Gemfile#L26 to restrict to < 7 would be an acceptable solution.

主要语言
Ruby
星标
2.3k
派生
546
PR 合并指标
30 天内没有已合并 PR

贡献指南

这个仓库没有索引到贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

JSONAPI-Resources/jsonapi-resources 的其他 Issue

查看 JSONAPI-Resources/jsonapi-resources 的全部 Issue

相似的 Issue

更多 Ruby Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。