Which backport PR labels should be added by the bot?
還沒有人認領這個 Issue。
評估
- 難度
- 5/5
- 預估耗時
- 一週以上
- 新手友好度
- 25/100
- Issue 類型
- 功能
- 描述清晰度
- 需要釐清
- 活躍度
- 停滯
- 技術堆疊
- github, javascript
- 領域
- tooling
研究方向
先閱讀 issue 116 中連結的討論,以及 pull request 90 和 pull request 118 中與 label 相關的上下文。接著檢視此處所述目前成功與失敗的標記規則,並釐清哪些 label 應自動套用,以及它們是服務於 PR 作者還是 release-staging 開發者。必須先在確定實作範圍之前達成一致的標記政策,才能視為完成。
由索引模型根據 Issue 內容生成。
描述
Moving an interesting discussion ignited in https://github.com/nodejs/github-bot/issues/116 into its own issue.
Which labels should the bot automatically add when it attempts backport of PRs?
First a description of the current auto labelling logic, so we're all on the same page when discussing how backporting labels should work as a whole.
Backport attempt fails
PR patch does not land cleanly against a staging branch.
If it is a LTS staging branch dont-land-on-v${version}.x is added*, otherwise a previously added lts-watch-v${version}.x might be removed as long as the user added the watch label was the github-bot.
Backport attempt succeeds
PR patch lands cleanly against a staging branch.
If its a LTS staging branch lts-watch-v${version}.x is added, otherwise a previously added dont-land-on-v${version}.x is removed if the user who added the dont-label label was the github-bot.
Introduce explicit auto labels?
In https://github.com/nodejs/github-bot/issues/116 there were several questions and concerns related to the dont-land-on-* labels especially. Those labels are used by devs deciding what should go into staging branches, to definitely stop any unwanted PRs (described in https://github.com/nodejs/github-bot/pull/90#issuecomment-261095822 and https://github.com/nodejs/github-bot/issues/116#issuecomment-275544912). There has been raised concerns about those hard stop labels automatically, since the bot adding that label currently means it does not land cleanly, which it sounds is not the real intention of dont-land-on-* labels.
There has previously been suggested introducing explicit auto labels for these automatic backport attempts, such as auto-merge-to-v7.x-failed or similar as described in https://github.com/nodejs/github-bot/issues/116#issuecomment-275181198.
Who is these auto labels intended for?
In addition to exactly which labels the bot should add based on these backport attempts, it seems to be some confusion about who these labels are intended for. The PR author or devs staging for releases?
* dont-land-on-* labelling has recently been temporary disabled: https://github.com/nodejs/github-bot/pull/118
- 主要語言
- JavaScript
- 星號
- 305
- 分支
- 148
- 平均合併
- 9 小時 2 分鐘
- 30 天內合併 PR
- 3
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
nodejs/github-bot 的其他 Issue
-
難度 3/5 1-2 天 新手友好度 45/100
nodejs/github-bot#308 · 2 則留言 ·
-
難度 4/5 3-5 天 新手友好度 20/100
nodejs/github-bot#283 · 3 則留言 ·
-
難度 5/5 一週以上 新手友好度 25/100
nodejs/github-bot#264 · 9 則留言 · 1 個 reaction ·
-
難度 3/5 1-2 天 新手友好度 35/100
nodejs/github-bot#262 · 2 則留言 ·
-
難度 4/5 3-5 天 新手友好度 35/100
nodejs/github-bot#251 · 5 則留言 ·
查看 nodejs/github-bot 的全部 Issue
相似的 Issue
-
bug
難度 2/5 1-3 小時 新手友好度 76/100
avniproject/avni-client#2135 ·
-
automated broken-link
難度 1/5 1 小時以內 新手友好度 85/100
-
agent/security hive/hosted-available-lke648397-260827-5n31 security
難度 2/5 1-3 小時 新手友好度 84/100
-
enhancement
難度 2/5 1-3 小時 新手友好度 70/100
babalae/bettergi-scripts-list#3674 ·
-
A-Release-Notes C-Editing D-Modest S-Ready-For-Implementation
難度 2/5 1-3 小時 新手友好度 72/100
bevyengine/bevy-website#2595 ·