Add extract to parameter refactoring for JS/TS in vscode

未關閉
#37,191 1 則留言 7 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

評估

難度
5/5
預估耗時
一週以上
新手友好度
32/100
Issue 類型
功能
描述清晰度
基本清楚
活躍度
停滯
技術堆疊
javascript, typescript
領域
developer-experience, devtools

研究方向

首先檢視 VS Code 整合中現有的 JavaScript/TypeScript 重構支援，以及 issue 中描述的範例行為。定義擷取出的運算式如何成為參數，以及每個現有呼叫點如何接收原始值；完成的標準是該重構對 JS 和 TS 都有效，且不改變無關的執行階段行為。

由索引模型根據 Issue 內容生成。

描述

Awaiting More Feedback Domain: LS: Refactorings Suggestion

Search Terms

Suggestion

Add a refactoring to extract to parameter for JS/TS

e.g.

for


const fangler = () => {
  return {
    someProperty: [
      "a", "b"
    ]
  }
}

the extract to parameter refactoring would change to


const fangler = (secondItem) => {
  return {
    someProperty: [
      "a", secondItem
    ]
  }
}

and populate each existing call site with the extracted value (in this example "b")

Use Cases

It is a common refactoring when you discover that a previously fixed value should instead be provided by a caller

Examples

e.g. in the case where I went looking for it code in a Lambda function that created a fixed header had to start providing a varying value depending on context and the easiest refactoring was to extract the currently fixed value as a parameter so that the callers that would vary it could do without breaking other callers

see https://twitter.com/mattbierner/status/1234920525543002113

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.
主要語言
Go
星號
111k
分支
14.4k
平均合併
1 天 19 小時
30 天內合併 PR
117

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

microsoft/TypeScript 的其他 Issue

查看 microsoft/TypeScript 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。