Support for all type features in declaration files.
還沒有人認領這個 Issue。
評估
- 難度
- 5/5
- 預估耗時
- 一週以上
- 新手友好度
- 15/100
- Issue 類型
- 功能
- 描述清晰度
- 需要釐清
- 活躍度
- 停滯
- 技術堆疊
- typescript
- 領域
- compilers
研究方向
未指定儲存庫檔案、測試或實作入口。先將要求縮小到特定的宣告輸出限制,例如 TS4094 或 TS4060,然後找出相關的編譯器行為,並定義能夠示範該功能具備同等行為的宣告輸出測試。
由索引模型根據 Issue 內容生成。
描述
I'm on TS 3.7.3 at time of writing this.
It seems like this issue should simply be focused on and fixed before continuing to add more and more features to the language and widening the source vs declaration gap.
This is quite a problem!
Search terms
"typescript declaration file limitations"
"has or is using private name"
"exported class expression may not be private or protected"
"Property 'foo' of exported class expression may not be private or protected. ts(4094)"
"Return type of exported function has or is using private name 'foo'. ts(4060)"
Related issues (a small fraction of the results on Google) in no particular order:
- https://github.com/microsoft/TypeScript/issues/29872 (@canonic-epicure)
- https://github.com/microsoft/TypeScript/issues/17744 (@fr0)
- https://github.com/Microsoft/TypeScript/issues/18791 (@johnnyreilly)
- https://github.com/microsoft/TypeScript/issues/30355 (@a-student)
- https://github.com/Microsoft/TypeScript/issues/17293 (@saschanaz)
- https://github.com/Microsoft/TypeScript/issues/24226 (@rjamesnw)
- https://github.com/gluons/vue-thailand-address/issues/5 (@gluons)
- https://github.com/types/sequelize/issues/176 (@billybarnum)
- https://github.com/microsoft/TypeScript/issues/6307 (@jeffschwartz)
- https://github.com/Microsoft/TypeScript/issues/23110 (@evil-shrike)
- https://github.com/typed-ember/ember-cli-typescript/issues/133 (@dfreeman)
- https://github.com/microsoft/TypeScript/issues/15947 (@ryansmith94)
- https://github.com/vuejs/vue/issues/6999 (@gluons)
- https://github.com/Microsoft/TypeScript/issues/16440 (@Manusan42)
- https://github.com/microsoft/TypeScript/issues/28754 (@trusktr)
- https://github.com/Microsoft/TypeScript/issues/5284 (@tommyZZM)
- https://github.com/Microsoft/TypeScript/issues/23280 (@mjbvz)
- https://github.com/gr2m/javascript-plugin-architecture-with-typescript-definitions/issues/1 (@gr2m)
- And the list on Google literally goes on and on and on. (I tried to skip any that were actual recognized bugs, fixed or not, but it may be possible I missed one or two, though the vast majority appear to be limitations of declaration files)
Workaround
One way to work around all of the above issues, for libraries, is to have library authors point their types field in package.json to their source entrypoint. This will eliminate the problems in the listed issues, but has some big downsides:
- If a downstream consumer of a library without declaration files (f.e. without
dist/index.d.ts) but withtypespointing to a source file (f.e.src/index.ts) then if the consumer'stsconfig.jsonsettings are not the same as the library's, this may cause type errors (f.e. the library hadstrictset tofalsewhile being developed, but the consumer setsstricttotrueand TypeScript picks up all the strict type errors in the library code).- This is documented in https://github.com/microsoft/TypeScript/issues/35744
- If
skipLibCheckis set to true, the consumer project's compilation will still type-check the (non-declaration) library code regardless.- This is documented in https://github.com/microsoft/TypeScript/issues/41883
With those two problems detailed, if you know you will be working in a system where you can guarantee that all libraries and consumers of those libraries will be compiled with the same compiler (tsconfig.json) settings (i.e. similar to Deno that defines compiler options for everyone), then pointing the package.json types field to a source file (because declaration output is not possible) is currently the workaround that allows all the unsupported features of declaration files to be usable. But this will fail badly if a library author does not know what compiler settings library consumers will have: everything may work fine during development and testing within external examples, but a downstream user will eventually report type errors if they compile their program with different settings while depending on the declaration-less libraries!
Suggestion
Support for all type features in declaration files.
Please. 🙏 I love you TS team, you have enabled so much better code dev with TypeScript. ❤️ 😊 TS just needs declaration love for support of all features of the language.
Some work is being done, f.e. https://github.com/microsoft/TypeScript/issues/23127, but overall I feel that too much effort is being put onto new language features while declaration output is left behind.
This creates a poor developer experience when people's working code doesn't work (the moment they wish to publish it as a library and turn on declaration: true).
I hope the amazing and wonderful TS team realize how frustrating it may feel for someone to work on a project for months, only to end with un-fixable type errors the moment they want to publish the code as a library with declaration: true, then having to abandon features and re-write their code, or try to point package.json "types" to .ts files only to face other issues.
I wish every new feature of the language came paired with working tests for equivalent declaration emit. Can this be made a requirement for every new language feature, just like unit tests are a requirement?
Use Case
Use any language feature, publish your code, then happily move along, without facing issues like
src/html/DeclarativeBase.ts:25:10 - error TS4094: Property 'onChildSlotChange' of exported class expression may not be private or protected.
25 function makeDeclarativeBase() {
~~~~~~~~~~~~~~~~~~~
src/html/WebComponent.ts:32:10 - error TS4060: Return type of exported function has or is using private name 'WebComponent'.
32 function WebComponentMixin<T extends Constructor<HTMLElement>>(Base: T) {
~~~~~~~~~~~~~~~~~
I worked hard for months to get the typings in the above code working, then I turned on "declaration": true and TypeScript said "today's not the day!".
I hope you the team can see that these issues are a pain, and realize the need to bring declaration emit to parity with language features and not letting the gap between language features and declaration output widen.
Examples
The issue that sparked me to write this was https://github.com/microsoft/TypeScript/issues/35744.
In that issue there's an example of what implicit return types might look like:
export declare function AwesomeMixin<T extends Constructor>(Base: T) {
type Foo = SomeOtherType<T> // only types allowed in here.
// only special return statements allowed, or something.
return declare class Awesome extends Base {
method(): Foo
}
}
We'd need solutions for other problems like the protected/private error above, etc.
Of course it'll take some imagination, but more importantly it will take some discipline: disallow new features without declaration parity.
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
- 主要語言
- Go
- 星號
- 111k
- 分支
- 14.4k
- 平均合併
- 1 天 19 小時
- 30 天內合併 PR
- 117
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
microsoft/TypeScript 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 88/100
microsoft/TypeScript#64322 · 2 則留言 · 1 個 reaction · 已指派 2 人 ·
-
Possible Improvement
難度 2/5 1-3 小時 新手友好度 78/100
microsoft/TypeScript#64278 · 1 則留言 · 1 個 reaction ·
-
Docs
難度 2/5 1-3 小時 新手友好度 70/100
microsoft/TypeScript#64118 · 1 則留言 ·
-
難度 1/5 1 小時以內 新手友好度 88/100
microsoft/TypeScript#64094 ·
-
Docs
難度 2/5 1-3 小時 新手友好度 76/100
microsoft/TypeScript#63959 · 5 則留言 ·
查看 microsoft/TypeScript 的全部 Issue
相似的 Issue
-
optimization optimization:agents-md-curator
難度 2/5 1-3 小時 新手友好度 86/100
githubnext/gh-aw-cao#13143 ·
-
難度 2/5 1-3 小時 新手友好度 84/100
blinklabs-io/bursa#904 ·
-
難度 2/5 1-3 小時 新手友好度 84/100
yanet-platform/ipfw-go#129 ·
-
bug confmap/provider/googlesecretmanagerprovider needs triage
難度 2/5 1-3 小時 新手友好度 72/100
open-telemetry/opentelemetry-collector-contrib#51273 · 2 則留言 ·
-
bug: AI Gateway client filter lists "Unknown" twice when NULL and literal Unknown clients coexist 未關閉bug
難度 2/5 1-3 小時 新手友好度 90/100