Rewrite Variable Logic From Scratch

未關閉
#137 4 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

評估

難度
5/5
預估耗時
一週以上
新手友好度
20/100
Issue 類型
重構
描述清晰度
需要釐清
活躍度
停滯
技術堆疊
powershell
領域
devtools

研究方向

No files or tests are named. Start by reviewing the scope and rule questions in this issue and linked issues #127, #129–#133, and #138; done requires a defined grammar rewrite covering the listed variable forms and highlighting cases, but the planned format is still TBD.

由索引模型根據 Issue 內容生成。

描述

enhancement project

There are multiple issues with variables as they stand now in the grammar some of which have been reported and some of which haven't:

  • Punctuation in variables with properties and methods isn't scoped correctly: #131
  • The sigil for a sub-expression is not handled the same way as the sigil on a variable: #132
  • Some language variables like $_, $$, $? are treated differently depending on context and are currently scoped incorrectly: #133
  • Properties and method highlighting breaks when the variable has an array position specified: #127
  • Multiple legal characters break variable highlighting ($Var?Iable), and special automatic variables like $<drive letter>:folder don't highlight correctly: #49

There are also questions about the correct scope of properties and methods (mentioned #131) and questions about to what extent the grammar should be concerned with user expectation/"most themes" vs either correctness (subjective) or consistency (with which languages?) (#130 and #129).

Background

The following cases need to be covered with as little repetition / complexity as possible:

  • Regular variables with and without scopes, properties, array position, methods, etc.
  • Variables contained within strings.
  • Variables contained within sub-expressions with and without scopes, properties, array position, methods, etc.
  • Variables in and out of strings and sub-expressions when using the ${Variable} format again with and without scopes, properties, array position, methods, etc.

The following gotchas need to be taken in to account:

  • Which special characters are legal within ${Variable} syntax vs $Variable syntax.
  • International characters (\p{L} vs [A-z]`).
  • Access of variables through splatting where the sigil is @.
  • Separate scoping for constants, automatic variables, language variables, etc.
  • $$ where "$$Hello" needs to show $$ as the variable and Hello as part of the double quoted string and other similar oddities.
  • Lots of others...

Planned Format/Rules

??? tbd

Re: Scope selection -> See #138

主要語言
PowerShell
星號
151
分支
55
PR 合併指標
30 天內沒有已合併 PR

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

PowerShell/EditorSyntax 的其他 Issue

查看 PowerShell/EditorSyntax 的全部 Issue

相似的 Issue

更多 DevTools Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。