`skyscraper/core/src/reduce`: These should live in some field arithmetic crate.

Open
#149 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
rust
Domain
cryptography

Research direction

Start with skyscraper/core/src/reduce.rs, especially its arithmetic and constants imports, and inspect the surrounding crate structure to identify an appropriate field arithmetic crate. The work is complete when the Bn254 scalar field reduction routines no longer belong in this module and their use remains supported through the chosen crate.

Written by the indexing model from the issue text.

Description

to do tracker

On 2025-08-27 in d91b2f2 “Merge pull request #142 from worldfnd/sl/skyscraper-refactor”:

These should live in some field arithmetic crate.

//! Bn254 scalar field modular reduction routines.
//!
//! TODO: These should live in some field arithmetic crate.

use {
    crate::{
        arithmetic::{less_than, overflowing_sub, sub},
        constants::{MODULUS, MODULUS_N_MINUS_RC},

From skyscraper/core/src/reduce.rs:3

Dominant language
Noir
Stars
138
Forks
47
Avg merge
1d 34m
Merged PRs (30d)
6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from worldfnd/provekit

All issues in worldfnd/provekit

Similar issues

More Cryptography issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.