OpenZeppelin / OpenZeppelin/compact-contracts
dev: move the curve runtime tests under crypto/curves
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 55
- Forks
- 29
- Avg merge
- 5d 7h
- Merged PRs (30d)
- 25
Description
contracts/src/crypto/test/CurveRuntimeInvariants.test.ts and MockCurveOps are the only files left at the crypto/ root after #918 grouped the modules by scheme. They pin a property of the Jubjub runtime, that every point reaching ecMul / ecAdd is forced into the prime-order subgroup, not a property of any scheme. Left where they are, the root reads as one more scheme directory with no module in it.
Move them under crypto/curves/, beside the bls12_381 field utilities from #913, with the mock under test/mocks/ and the artifact import depth adjusted.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with contracts/src/crypto/test/CurveRuntimeInvariants.test.ts and locate MockCurveOps. Move the runtime test under crypto/curves/ and the mock under test/mocks/, adjusting the artifact import depth. Done means the tests still verify the Jubjub subgroup property and pass from their new locations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- cryptography, testing
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 82/100