wavefnd / wavefnd/Wave

Add focused tests for FreeBSD VM console parsing

Offen Anfängerfreundlich
#653 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
good first issue needs testing
Vorherrschende Sprache
Rust
Sterne
53
Forks
16
Ø Merge
4 Std. 22 Min.
Gemergte PRs (30 T.)
46

Beschreibung

## Current evidence

`tools/check_freebsd_sys.py` contains a `Console` helper that incrementally reads the QEMU serial stream, appends bytes to a text buffer, searches regular expressions across reads, consumes matched prefixes, reports EOF, and enforces timeouts.

Those behaviors are independent of actually booting FreeBSD, but they are currently exercised only as part of the full VM workflow. Regressions in split serial output or buffer consumption therefore require an expensive QEMU run to detect.

## Scope

- Add focused Python unit tests for `Console.expect` without launching QEMU or requiring a FreeBSD image.
- Cover a match contained in one read and a match split across multiple reads.
- Verify matched text is consumed while later buffered output remains available to the next `expect` call.
- Cover EOF before a match, timeout behavior, and guest-log writes.
- Keep the production VM boot and shutdown flow unchanged.

## Completion criteria

- Tests run on a normal development/CI host with only the Python standard library.
- No QEMU, firmware, disk image, network, or compiler invocation is required by the focused tests.
- Existing FreeBSD system-test behavior remains unchanged.

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start with tools/check_freebsd_sys.py and trace Console.expect, including its buffering, EOF, timeout, and guest-log behavior. Add focused standard-library unit tests for single-read and split-read matches, consumption with later buffered output, EOF, timeouts, and log writes; done means they run without QEMU or FreeBSD assets while the existing VM flow remains unchanged.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
python
Bereich
operating-systems, testing-qa
Issue-Typ
Feature
Schwierigkeit
2/5
Geschätzter Aufwand
Ein halber Tag
Aktivitätsstatus
Aktiv
Klarheit
Klar beschrieben
Anfängerfreundlichkeit
84/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.