make need of execCommand to hide table controls go away on FF

Open
#171 12 comments 9 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
web-dev

Research direction

Start by reviewing the execCommand behavior described in the issue and the referenced CKEditor plugin implementation. Compare Firefox's table-control behavior with other browsers and determine how the editing specification should express the expected result. Done means the required behavior is clearly defined without relying on global commands.

Written by the indexing model from the issue text.

Description

execCommand

On Firefox, one needs to execute these two execCommands globally to make table controls go away. Table controls are generally implemented in JavaScript anyway, and this makes the Firefox implementation work differently than any other browser.

Can we make it clear that there should be no table controls to begin with, as is the case on all browsers except Firefox? All known editors execute these two commands after loading a page to make the table commands go away. Apparently these are global settings that work for all tables on a page.

 document.execCommand("enableObjectResizing", false, false) 
 document.execCommand("enableInlineTableEditing", false, false) 

See for example:

https://github.com/ckeditor/ckeditor-dev/blob/fc149eeb4b92ba9ea64c6becee9e0ddff906097f/plugins/wysiwygarea/plugin.js#L554-L558

Dominant language
HTML
Stars
202
Forks
43
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from w3c/editing

All issues in w3c/editing

Similar issues

More Web Dev issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.