voidzero-dev / voidzero-dev/vite-plus

Inject `PNPM_CONFIG_RUNTIME=false` when `vp env` is `managed`

Ouverte
#2,468 9 commentaires 2 réactions 1 personne assignée Réclamée par @liangmiQwQ Voir sur GitHub
enhancement
Langage dominant
Rust
Étoiles
5.8k
Forks
262
Merge moyen
23 h 18 min
PR mergées (30 j)
139

Description

### Description

`pnpm` itself has a runtime version management system, means the same Node.js version might be downloaded twice by both Vite+ and pnpm.

### Suggested solution

When `vp env` is set to `managed` mode, we can inject `PNPM_CONFIG_RUNTIME=false` in the shell script.

Also, when users call `vp env off` / `vp env on`, Vite+ should also change the status of this env variable.

This can be also shown in `vp env doctor` (Suggested by @ TheAlexLichter)

### Alternative

N / A

### Additional context

Context: https://discord.com/channels/1475973262193459293/1479410337223802951/1538525485166760026

### Validations

- [x] Read the [Contributing Guidelines](https://github.com/voidzero-dev/vite-plus/blob/main/CONTRIBUTING.md).
- [x] Confirm this request is for Vite+ itself and not for Vite, Vitest, tsdown, Rolldown, or Oxc.
- [x] Check that there isn't already an issue requesting the same feature.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.