voidzero-dev / voidzero-dev/vite-plus

defineConfig always injects vite-plus:vitest-resolver into vp build / vp dev even when Vitest isn't used

Aperta
#2,307 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
pending triage
Lingua principale
Rust
Stelle
5.8k
Fork
261
Merge medio
1g 34m
PR unite (30g)
135

Descrizione

### Describe the bug

`defineConfig` from `vite-plus` always prepends Vitest-only plugins into every Vite config, including for `vp build` / `vp dev`:

- `vite-plus:vitest-resolver`
- `vite-plus:auto-inline-matcher`
- `vite-plus:coverage-version-guard`

Projects that use Vite+ for toolchain (`fmt` / `lint` / `build`) but run tests with another runner (e.g. Bun's `bun:test`) still pay for these plugins on every production build.

Rolldown/Vite plugin timings report:

```text
[PLUGIN_TIMINGS] Your build spent significant time in plugins. Here is a breakdown:
- vite-plus:vitest-resolver (87%)
```

The resolver is an `enforce: "pre"` `resolveId` hook, so it runs on every module resolve. It early-returns for non-`vitest` / `@vitest/*` ids, but with a large graph that still dominates **plugin** time.

There is no documented opt-out. `lazyPlugins` only gates *user* plugins during config-metadata loads; it does not skip these injected plugins on `build`/`dev`. `vite-plus/prefer-vite-plus-imports` also pushes app configs to import `defineConfig` from `vite-plus` rather than `vite`, so switching away isn't a clean escape hatch.

### Reproduction

1. Use `import { defineConfig } from "vite-plus"` in an app `vite.config.ts`
2. Do **not** configure or run `vp test` / Vitest
3. Run `vp build` (with plugin timings enabled)
4. Observe `vite-plus:vitest-resolver` near the top of `[PLUGIN_TIMINGS]`

### Expected

Vitest helper plugins should only be injected when running tests (`vp test` / Vitest), or there should be an explicit opt-out for projects that don't use Vitest.

### System Info

- `vite-plus`: `0.2.5`
- Tests: Bun (`bun:test`), not Vitest
- Apps build via `vp build`

### Suggested fix

- Gate injection on test command / presence of `test` config, **or**
- Add a config flag such as `test: false` / `vitest: false` to skip injection, **or**
- Document a supported way to opt out without fighting `prefer-vite-plus-imports`

### Related

- Implementation that introduced/patched the resolver: https://github.com/voidzero-dev/vite-plus/pull/356
- Auto-inline matcher: https://github.com/voidzero-dev/vite-plus/pull/1113
- `lazyPlugins` (user plugins only): https://github.com/voidzero-dev/vite-plus/pull/1215

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Reproduce the issue with a vite.config.ts that imports defineConfig from vite-plus and run vp build with plugin timings enabled. Read the resolver and auto-inline matcher changes in PRs 356 and 1113, then trace how vp build, vp dev, and vp test inject them; done means non-test commands no longer incur Vitest-only plugins or have a documented opt-out.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
bun, typescript
Ambito
build-system, tooling
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Tranquilla
Chiarezza
Abbastanza chiara
Idoneità per principianti
52/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.