voidzero-dev / voidzero-dev/vite-plus

Contribution setup does not initialize git hooks

Aperta
#1,470 1 commento 0 reazioni 1 assegnatario Rivendicata da @fengmk2 Vedi su GitHub
Lingua principale
Rust
Stelle
5.8k
Fork
261
Merge medio
1g 34m
PR unite (30g)
135

Descrizione

The documented contributor setup runs `just init`, which runs `pnpm install`.

The root package has `prepare: husky`, but `pnpm-workspace.yaml` sets `ignoreScripts: true`, so `prepare` is skipped and Husky is never initialized. As a result, `.husky/pre-commit` / `lint-staged` do not run for contributors by default.

What should the project do here?

- Migrate the root repo to the built-in `vp config` + `vp staged` flow, and have `just init` install hooks explicitly.
- Or keep Husky/lint-staged and explicitly initialize Husky during contributor setup.

I can contribute the fix once the preferred direction is clear.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.