voidzero-dev / voidzero-dev/vite-plus

Contribution setup does not initialize git hooks

Open
#1,470 1 comment 0 reactions 1 assignee Claimed by @fengmk2 View on GitHub
Dominant language
Rust
Stars
5.8k
Forks
261
Avg merge
1d 34m
Merged PRs (30d)
135

Description

The documented contributor setup runs `just init`, which runs `pnpm install`.

The root package has `prepare: husky`, but `pnpm-workspace.yaml` sets `ignoreScripts: true`, so `prepare` is skipped and Husky is never initialized. As a result, `.husky/pre-commit` / `lint-staged` do not run for contributors by default.

What should the project do here?

- Migrate the root repo to the built-in `vp config` + `vp staged` flow, and have `just init` install hooks explicitly.
- Or keep Husky/lint-staged and explicitly initialize Husky during contributor setup.

I can contribute the fix once the preferred direction is clear.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.