voidzero-dev / voidzero-dev/oxc-angular-compiler
security: missing security-context entries for SVG animation, iframe i18n, and namespaced SVG script elements
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Rust
- Estrellas
- 228
- Forks
- 20
- Merge medio
- 1 d 15 h
- PR fusionados (30 d)
- 36
Descripción
Summary
Three security-context tables in OXC are missing entries that landed in packages/compiler since v21.2.2. Each gap creates a small XSS or unsanitized-binding surface in templates compiled by OXC.
Sub-gaps
1. iframe|src missing from TRUSTED_TYPES_SINKS
Upstream: packages/compiler/src/schema/trusted_types_sinks.ts:28 (added in 78dea55351).
ngc registers iframe|src so the i18n translation pipeline cannot rewrite the src attribute on iframes — translated strings flowing into iframe sources is an XSS vector. OXC has no trusted_types_sinks.rs equivalent in crates/oxc_angular_compiler/src/schema/.
Required work: create crates/oxc_angular_compiler/src/schema/trusted_types_sinks.rs mirroring upstream's set, wire into the i18n extractor's isTranslatableAttribute check.
2. SVG animation attributes missing from URL security context
Upstream: packages/compiler/src/schema/dom_security_schema.ts:108-113 (added in 08d36599d7).
ngc registers animate|to, animate|from, animate|values, and set|to as SecurityContext.URL, ensuring [attr.to]="..." on an SVG <animate> element runs through URL sanitization. OXC at crates/oxc_angular_compiler/src/schema/dom_security_schema.rs:30-110 registers only animate|attributename (and similar non-value attrs), leaving the value attrs in the default no-binding context — they bypass sanitization.
Required work: add the four entries to the URL group in dom_security_schema.rs.
3. Namespaced SVG script elements not classified as script-like
Upstream: packages/compiler/src/template_parser/template_preparser.ts:17-18,41-43 (added in 90494cd909).
ngc's preparseElement treats both script and :svg:script as script elements (and :svg:style as a style element), stripping their content during template compilation. OXC has no template-preparser equivalent — <svg:script> survives template compilation as a normal element, executing at runtime.
Required work: introduce a template-preparser pass (or extend the existing element classification) under crates/oxc_angular_compiler/src/parser/ that recognizes the SVG-namespaced variants.
Why this matters
Each gap is small, but together they widen OXC's attack surface vs ngc:
- Sub-gap 1 lets an i18n translation team inject iframe content
- Sub-gap 2 lets SVG animation attributes accept unsanitized URLs (
javascript:etc.) - Sub-gap 3 lets SVG script elements execute
All three fixes are data-table or detection-logic additions, no architectural work.
Reference
- Trusted types:
packages/compiler/src/schema/trusted_types_sinks.ts - DOM security schema:
packages/compiler/src/schema/dom_security_schema.ts - Template preparser:
packages/compiler/src/template_parser/template_preparser.ts
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Compara trusted_types_sinks.ts, dom_security_schema.ts y template_preparser.ts de upstream con los archivos de esquema Rust correspondientes y el parser en crates/oxc_angular_compiler/. Empieza con la comprobación existente de atributos i18n, la tabla de seguridad DOM y la clasificación de elementos. Se considera terminado cuando iframe|src queda excluido de la traducción, los cuatro atributos de animación SVG usan seguridad de URL y los elementos script/style con espacio de nombres SVG reciben la clasificación requerida.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- rust, typescript
- Área
- compilers, security
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Tranquilo
- Claridad
- Bastante claro
- Aptitud para principiantes
- 55/100