Allow specifying a WS closing code to TemplatedApp.close()
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- cpp
- Domain
- backend, networking
Research direction
Start at the C++ implementation of TemplatedApp.close() and trace how WebSocket connections are closed. Determine how a caller could provide a WebSocket closing code, then verify that connected clients receive that code when the server shuts down.
Written by the indexing model from the issue text.
Description
Hello,
As per documentation, the TemplatedApp.close() method "closes all sockets including listen sockets". For WS servers this means that all WS connections are closed without a closing code (I'm guessing the underlying TCP socket is the one that is actually closed) and the reported code is 1006.
It would be useful to have a way for specifying the WS closing code to send to the clients. This way, applications can identify and handle on the client side the situation of a server being closed.
- Dominant language
- C++
- Stars
- 19k
- Forks
- 1.9k
- Avg merge
- 3h 24m
- Merged PRs (30d)
- 5
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from uNetworking/uWebSockets
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
uNetworking/uWebSockets#1945 · 3 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
uNetworking/uWebSockets#1936 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 50/100
uNetworking/uWebSockets#1931 · 5 comments ·
-
Client Support Open
Difficulty 5/5 Over a week Newbie friendliness 25/100
uNetworking/uWebSockets#1920 · 1 comment ·
-
low priority
Difficulty 4/5 3-5 days Newbie friendliness 35/100
uNetworking/uWebSockets#1909 · 2 comments ·
All issues in uNetworking/uWebSockets
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
Sensor initialization takes very long when `--initial-sim-time` is set to current UNIX timestamp Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
gazebosim/gz-sensors#662 · 1 comment ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
comp-datalake
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
ClickHouse/ClickHouse#121222 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
LadybirdBrowser/ladybird#12123 ·