Is spatialsample ready for v1.0.0?

Open
#147 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
r
Domain
release

Research direction

Review spatialsample's current interface and returned objects in relation to rsample >= 1.0.0, then assess the open concerns around stratification and the experimental spatial_nndm_cv() entry point. Done means reaching a maintainer decision on whether the package is ready for a 1.0.0 release.

Written by the indexing model from the issue text.

Description

upkeep

I think spatialsample is ready for version 1.0.0. We're building on top of rsample >= 1.0.0, which has had a pretty stable interface for multiple years, and I'd be surprised myself if much of the interface or the returned objects changed in the future.

The main reasons spatialsample wouldn't be 1.0.0 ready that I can think of would be:

  • Stratification isn't supported, and isn't currently on the short-term roadmap (but might be in the future). This might cause a big change to the package.
  • spatial_nndm_cv() is still somewhat experimental and might change in the future, as the team that introduced NNDM is talking about proposing a V-fold variant.

Still, I think we're in a place where the next release could be a 1.0.0 release. I'm opening this issue to see what others think!

Dominant language
R
Stars
80
Forks
6
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tidymodels/spatialsample

All issues in tidymodels/spatialsample

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.