theupdateframework / theupdateframework/python-tuf

document dependabot PR review strategy

Ouverte
#2,014 11 commentaires 0 réactions 2 personnes assignées Voir sur GitHub

@lukpueh y travaille déjà.

Depuis le 15/6/2022.

documentation
Langage dominant
Python
Étoiles
1.7k
Forks
304
Merge moyen
1 j 2 h
PR mergées (30 j)
17

Description

This is what I believe makes sense:

  • "test" dependencies are mostly pinned to make sure we know which versions are being used and that the current version doesnt't surprisingly start breaking builds: reviewing the contents of test dependency updates is not required. If the tests pass that should be fine. Major updates could warrant a look in the changelog
  • actual run time dependency updates should be reviewed: what this means is case dependent, but as a minimum we should check the changelog. Reading the commit log or actual changes may be useful but can also be an unrealistic goal for some dependency updates.
  • The purpose of the dependency review is two-fold:
    • prevent depending on software that works differently than we expect (so API changes, other functionality changes, bugs)
    • prevent depending on software that is actually malicious (this is more relevant the newer the update is as a lot of malicious updates are noticed fairly quickly). It should be noted that pypi package can be malicious without the malicious code being in github: source code review only goes so far.

This isn't documented anywhere: it should be

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.