testcontainers / testcontainers/testcontainers-python

`ElasticSearchContainer` method `.get_url()` suggested in doc websites but not implemented anymore

Open
#980 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2.3k
Forks
386
Avg merge
4h 40m
Merged PRs (30d)
1

Description

The docs in https://testcontainers.com/modules/elasticsearch/?language=python still suggest the usage of the method .get_url() for the container, which however was removed in the following commit:

https://github.com/testcontainers/testcontainers-python/commit/c785ecdca20b51e077ab23ed61ae123c643a0627.

I see that also the docs in https://testcontainers-python.readthedocs.io/en/latest/modules/elasticsearch/README.html still suggest to use the .get_url() method.

I tried to take a look at the examples in this repo and they don't seem to suggest .get_url(), I honestly don't know if this is the right place to report this but I don't know of a better place at the moment.

Thank you very much for the attenion

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Elasticsearch module documentation at the testcontainers.com page and the readthedocs README, then inspect the repository's documentation sources and commit c785ecdca20b51e077ab23ed61ae123c643a0627. Update the documentation so it no longer recommends the removed .get_url() method, and verify both published examples are consistent with the current API.

Written by the indexing model from the issue text.

Assessment

Tech stack
elasticsearch, python
Domain
databases
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.